Repository navigation
Show checkbox filter counts - #130
Merged
Merged
Conversation
… viewing dynamically updated counts for the checkbox filter values that appear in an evaluator's results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkbox filters on the evaluator view currently show all the potential values for each field, even though many of the values are not actually present in the evaluator's results, making it easy to apply a set of filters that returns zero results.
We now have an API endpoint that returns counts for the checkbox filter fields' values, so this PR adds a first pass at showing those counts. The functionality is hidden behind a querystring flag so we can test it without impacting the existing filters.
Additions
show_countsquery param to toggle between the current filters and the new implementation with countsTesting
Screenshots
Checklist
Testing checklist
Browsers
Accessibility
Other