implement Elbencho S3 run loop and pdsh command builder (Story 3) - #360
Draft
gitkenan wants to merge 3 commits into
Draft
implement Elbencho S3 run loop and pdsh command builder (Story 3)#360gitkenan wants to merge 3 commits into
gitkenan wants to merge 3 commits into
Conversation
gitkenan
force-pushed
the
elbencho-pdsh-init
branch
from
August 12, 2026 10:02
674ad3b to
9073b13
Compare
gitkenan
changed the title
gitkenan
force-pushed
the
elbencho-pdsh-init
branch
from
August 12, 2026 11:20
9073b13 to
7b5cf06
Compare
gitkenan
force-pushed
the
elbencho-pdsh-init
branch
2 times, most recently
from
August 12, 2026 11:35
eaf8f90 to
edb4a17
Compare
gitkenan
marked this pull request as draft
August 12, 2026 11:36
gitkenan
force-pushed
the
elbencho-pdsh-init
branch
2 times, most recently
from
August 12, 2026 17:24
e3203f6 to
052a218
Compare
gitkenan
force-pushed
the
elbencho-pdsh-init
branch
from
August 12, 2026 17:47
052a218 to
d64855f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story 3 of 11
This fills in the _run_workloads() stub from Story 2. The three-tier nested loop (blocksize → threads → iodepth) now runs for real: for each cell it creates the run directory, builds the elbencho shell command, and fans it out to all client nodes via a single pdsh broadcast. The one non-obvious decision is the namespace-collision fix — rather than looping per-host, the bucket path is suffixed with $(hostname -s) inside the command string so the remote shell expands it independently on each node, matching the pattern already used by rbdfio for RBD volume naming.
stat and list modes are skipped with a warning per Story 5's explicit deferral decision; they produce no throughput or blocksize metrics so the formatter isn't ready for them yet.
32 new tests cover the blocksize parser, auth flag builder, command builder, and run-loop call count/path structure. Total test count: 54, all passing.