fix(acquire): keep the lease's role for the same database

[simoncrypta]

Beads: cedar-pg-n8i

Problem

acquire derived the role name on every call (src/core/lifecycle.ts). After #44 changed role naming for long worktree names, any existing dev database whose name exceeds 58 characters now maps to a new role. ensureDatabase then hands the database to that role, while the tables inside stay owned by the old one, so the app gets permission denied on its own dev data. The rewritten lease also drops the old role, which is left orphaned. The CHANGELOG claim "existing leases keep their stored role" only held until the next acquire.

Fix

• acquire reuses the role stored in an existing lease when that lease is for the same database. It keeps writing that role into the lease, and fresh drops by it.
• A lease for a different database, or no lease at all, still uses the new fix(naming): keep full mode + hash in role and clone names #44 naming, so new databases get it.
• The CHANGELOG entry for fix(naming): keep full mode + hash in role and clone names #44 now describes the real behaviour, including the no-lease caveat: without the lease file, a pre-existing long-named database still needs a manual drop or a restored lease.

I picked lease reuse over REASSIGN OWNED, as the bead asked. It's a two-line change in the canonical layer and needs no per-database connection.

Tests

• New tests/lifecycle-acquire.test.ts (mocked host and provider) covers three cases:
  • an existing lease with the old cut role for the same 63-char database: acquire keeps that role for ensureDatabase, fresh and the lease;
  • a lease for a different database: the derived role is used;
  • no lease: the derived role is used.
• The first case fails without the fix and passes with it.
• Live check, run once by hand, not in CI: an owned throwaway autopg postmaster on a temp port and data dir (never the shared host), with a stub AUTOPG_BIN reporting that port, drove the built acquire.
  • Seeded lease with the old role: the role is kept and the seeded row reads back.
  • Lease removed: the derived role gets 42501 permission denied for table t. That is the pre-fix failure.
• smoke:pg does not cover this upgrade path.

Checks

• vp check: pass
• vp test: 22 files, 138 tests pass
• vp run smoke:pg: pass

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 28cc23ed-c85b-47ab-90fc-5de059126613

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@cedarjs/pg@51

commit: 3840edd