Skip to content

Added regex_find_replace operation for Issue587 coverage - #1810

Closed
aniemes wants to merge 9 commits into
cdisc-org:mainfrom
aniemes:587_corerules_1689
Closed

Added regex_find_replace operation for Issue587 coverage#1810
aniemes wants to merge 9 commits into
cdisc-org:mainfrom
aniemes:587_corerules_1689

Conversation

@aniemes

@aniemes aniemes commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Fix for issue 587

  • added the regex_find_replace operation and wired it into operation parsing and registration
  • updated rule schema support for regex_find_replace
  • added unit coverage for the new operation
  • added CoreIssue587 regression coverage with dataset fixtures for paired, missing, boundary, mixed, and noise cases

@aniemes aniemes changed the title Add regex_find_replace operation and CoreIssue587 coverage Added regex_find_replace operation for Issue587 coverage Jul 23, 2026
@aniemes aniemes linked an issue Jul 23, 2026 that may be closed by this pull request

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please mention why is this bundled version being added here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RamilCDISC!
I added this file by running the bundle_json_schema.py script since Operations.json was updated to define the new regext_find_replace operator and the bundled file has to be in sync with the source file.

Comment thread cdisc_rules_engine/operations/regex_find_replace.py Outdated
@aniemes

aniemes commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator Author

This was created with the incorrect HEAD, it has been replaced by PR 1814.

@aniemes aniemes closed this Jul 30, 2026
@aniemes
aniemes deleted the 587_corerules_1689 branch July 30, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule blocked: CORERULES-1689

2 participants