1443 Send49 Rule Blocked Fix#1806
Open
aniemes wants to merge 13 commits into
Open
Conversation
added 4 commits
July 16, 2026 14:32
Changes made to add the new columns to the documentation
…no variable level codelist and test where VSORRESU is not flagged when it has a variable level codelist
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
added 2 commits
July 22, 2026 13:31
…rg/cdisc-rules-engine into 1443_rule_blocked_send49
RamilCDISC
requested changes
Jul 24, 2026
| on="variable_name", | ||
| ) | ||
| final_dataframe = final_dataframe.drop( | ||
| columns=["define_variable_name_y"], errors="ignore" |
Collaborator
There was a problem hiding this comment.
Given vlm-summary is renamed to variable_name. There is no define_variable_name column collision left at this point. This drop looks like a leftover form earlier iteration. Could you please remove it or add a comment explaining if its covering any edge case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #1443
Added Value Level Metadata support for the Variable Metadata Check against Define XML and Library Metadata.
Extended VariablesMetadataWithDefineAndLibraryDatasetBuilder to extract and aggregate VLM data from Define xml.
Added metadata variables: define_vlm_present, define_vlm_item_count, define_vlm_ccodes, define_vlm_has_codelist_any, define_vlm_has_codelist_all, define_vlm_ccode_missing_any, define_vlm_ccode_matches_library_any, define_vlm_ccode_matches_library_all
Updated the schema documentation
Created regression test for the issue and tested flagging and none flagging scenarios.