csv report errors#1803
Conversation
| result.get("executionStatus") | ||
| == ExecutionStatus.EXECUTION_ERROR.value | ||
| ): | ||
| for error in self._error_details(validation_result, result): |
There was a problem hiding this comment.
the _error_details() function is already called once per result in _generate_error_details() function during init (to build data_sheets["Issue_details"] and is now called here again for the same result. Could we compute it once and cache/resuse it instead of running it twice?
| result.get("executionStatus") | ||
| == ExecutionStatus.EXECUTION_ERROR.value | ||
| ): | ||
| for error in self._error_details(validation_result, result): |
There was a problem hiding this comment.
This loop also processes the EXECUTION_ERROR entries that already exist in the ISSUE_DETAILS, but we only skip re-adding them because their variables/attributes field happen to be "" so zip() produces nothing,. If this empty field behavior ever changes this will silently start double counting the execution errors in the csv.
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR resolves some csv report errors. The validation was done by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR in accordance with AC.
- Reviewing the PR for updated tests.
- Reviewing the attached csv reports.
- Ensuring all unit and regression testing pass.
- Ensuring results are coherent after update.
- Ensure the update made is not fragile and ensures proper working for edge cases.
- Ensure full integration in existing system.
2 participants
fixes bug where errors were not reported on CSV and a successful execution versus an error execution looked identical
CORE-Report-2026-07-10T14-58-03.csv
CORE-Report-2026-07-10T15-13-33.csv