Skip to content

update published rules action only focuses on filtered standards - #85

Merged
SFJohnson24 merged 18 commits into
mainfrom
update-filtered-rules
Jul 27, 2026
Merged

update published rules action only focuses on filtered standards#85
SFJohnson24 merged 18 commits into
mainfrom
update-filtered-rules

Conversation

@gerrycampion

@gerrycampion gerrycampion commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

@gerrycampion
gerrycampion marked this pull request as draft July 16, 2026 15:34
@gerrycampion gerrycampion added this to the v1.0.0 milestone Jul 16, 2026
@gerrycampion
gerrycampion marked this pull request as ready for review July 17, 2026 14:56
@gerrycampion
gerrycampion requested a review from SFJohnson24 July 17, 2026 14:56
exit 0
fi

CORE_IDS_TO_RUN="$(venv/bin/python .github/scripts/filter_core_ids_by_standard.py \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if I am misunderstanding the script flow, we can pass the core ids first time the filter_core_ids_by_standard.py script is run. Could you please mention the intention behind running the script twice?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamilCDISC I removed the double call if you could please re-review

@SFJohnson24
SFJohnson24 requested a review from RamilCDISC July 24, 2026 15:00

@RamilCDISC RamilCDISC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the action for updating published rules to focus only on filtered datasets. The filtered standards are USDM and TIG. The action has been reviewed for proper implementation and update according to AC. The python script is validated for proper input take and processing of filtered standards. Efficient use of the python script was ensured. The description has a link to sample run.

@SFJohnson24
SFJohnson24 merged commit 685911f into main Jul 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants