Skip to content

Results - #73

Merged
gerrycampion merged 10 commits into
mainfrom
unsorted
Jul 3, 2026
Merged

Results#73
gerrycampion merged 10 commits into
mainfrom
unsorted

Conversation

@SFJohnson24

@SFJohnson24 SFJohnson24 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

This PR does a few things:

  • reran all published rules and replaced floats that are now correctly cast as such due to using the metadata files per csv reader to use _variables metadata file cdisc-rules-engine#1768
  • also during the rerun, replaces all of the results files with actual results if the only difference is the row order. This is to enable @gerrycampion code
    # Uncomment this if we care about row order changes
    # if exp_content != act_content:
    # return [
    # "Row order changed: rows are identical but appear in a different order"
    # ]
    which will ignore unordered differences when comparing the results files.
  • While rerunning rules, if results did not exist, it added the results dir, if it was positive and the rule executed successfully with no results--it would populate the results.csv It did not do this for negative as these require some scrutiny as to their validity.

@SFJohnson24 SFJohnson24 self-assigned this Jul 2, 2026
@SFJohnson24
SFJohnson24 requested a review from gerrycampion July 2, 2026 19:19
@gerrycampion
gerrycampion merged commit a6bc99a into main Jul 3, 2026
3 checks passed
@gerrycampion
gerrycampion deleted the unsorted branch July 3, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants