action to update published rule results - #59
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # ----------------------------------------------------------------------- | ||
| - name: Run engine and write results | ||
| id: run_engine | ||
| continue-on-error: true |
There was a problem hiding this comment.
While I understand that we want the execution to continue even if rule validation failed, this will still continue and make a PR even if there is an error invoking the CORE or some other execution error. I suggest adding a check or completion marker to prevent creating PR's when this workflow run failed because of some reason. Also the workflow run will just pass even if the execution failed if we do not add a check.
There was a problem hiding this comment.
@RamilCDISC
This is the behavior I want for now. Even if one of the CORE invocations fail or have an execution error, I still want the PR to be created for the other rules. The job should only fail if the PR can't be created.
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds an action to update published rules result by creating a PR with updates. The pipeline is clear and well written. The continuation on error is intentional. The sample pipeline run and PR proves proper implemenetation.
3 participants
Combines functionality similar to CORE_Test_Suite\.github\workflows\update_templates.yaml and cdisc-rules-engine\.github\workflows\validate-published-rules.yml to create a new github workflow in the cdisc-open-rules repo that works similar to validate-published-rules, but instead of creating a comparison report, it just pushes the actual results to a new branch and creates a new PR similar to the way that the update_templates works
Sample action run: https://github.com/cdisc-org/cdisc-open-rules/actions/runs/28279541856
Sample PR created (not ready for review yet): #60