PHPCodesniffer errors in Atom #104

Activity

1. GaryJones commented on May 29, 2017

   

   GaryJones

   on May 29, 2017

   Collaborator

   More actions

   This section is only supported in WPCS 0.12.0. The latest release is 0.11.0, but I run the develop branch of WPCS, so don't get any errors. Chances are, 0.12.0 should be out before UP 2, but if not, we can delete that section before release.

   See https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#naming-conventions-prefix-everything-in-the-global-namespace
2. jdelia commented on May 29, 2017

   

   jdelia

   on May 29, 2017

   CollaboratorAuthor

   More actions

   Thanks @GaryJones
3. jdelia commented on May 29, 2017

   

   jdelia

   on May 29, 2017

   CollaboratorAuthor

   More actions

   @GaryJones what version of PHP_CodeSniffer are you running?
4. GaryJones commented on May 29, 2017

   

   GaryJones

   on May 29, 2017

   Collaborator

   More actions

   2.9.0
5. jdelia commented on May 29, 2017

   

   jdelia

   on May 29, 2017

   CollaboratorAuthor

   More actions

   I am on 2.9.1 and after updating to WPCS 0.12.0 - this is the only error I receive:

   Error running PHPCS Error: PHP Fatal error: Uncaught Error: Call to undefined function did_action() in /Users/loneduchess/Local Sites/utility-pro-2/app/public/wp-content/themes/utility-pro/vendor/tgmpa/tgm-plugin-activation/class-tgm-plugin-activation.php:2109(…)

   https://cl.ly/220g3f3w2A0T
6. GaryJones commented on May 29, 2017

   

   GaryJones

   on May 29, 2017

   Last edited by GaryJones

   Collaborator

   More actions

   @jdelia

   We're trying to fix that in TGMPA.

   Add the following to the top of it the TGMPA class file:

   // Exit if accessed directly.
   if ( ! defined( 'ABSPATH' ) ) {
   	return;
   }

   See https://github.com/TGMPA/TGM-Plugin-Activation/blob/9f63adeb10dcadd8733757e5c9c23e137cc8faff/class-tgm-plugin-activation.php#L35-L38 and TGMPA/TGM-Plugin-Activation#665