Repository navigation
Sign each journal line with the account that made the change - #779
Merged
Merged
Conversation
A change to a database, a method collection or the scenarios of a database
now records who made it, next to when. The server in front of the engine
names the account (Volca-Reader) and its public name (Volca-Author-Handle);
with both, the line carries "by": {"account", "handle"}. Without them, as on
the desktop, the line is written as before, and older lines still read.
The account id stays stable while the public name can change: the line keeps
both, the name as it was that day and the account to find it again. The
history of a database and of a collection returns the name as "by", and the
changes report of an export says "By: @name" above the reason. Replaying a
journal never looks at the author.
The reader header is now read on every request, not only when the usage log
is on, so signing does not depend on counting. Wire revision 102.
… signed A blank Volca-Author-Handle now counts as no name, so a line is never signed "@" with nothing after it. The MCP takes who sent a request as one Caller, the reader and the author together, instead of two parameters side by side. The README says which headers sign a change, next to the usage log's.
Main took revision 102 for the basis of a score and 103 for the method catalogue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each change to a database, a method collection or the scenarios of a database now says who made it.
The server in front of the engine already names the account on every request (
Volca-Reader). It will also send the account's public name (Volca-Author-Handle). When both are there, the journal line carries"by": {"account": "acc-1", "handle": "ana"}next to its time. When they are not, as on the desktop, the line is written exactly as before, and older lines read as made by nobody.by, the public name.By: @anaabove the reason.Wire revision 104.
Checked on a local engine: a copy edited with both headers has
"by"on its journal line andby: "ana"in its history; the same edit without them has neither.