Repository navigation
Say what a score rests on beside its contributions and its sensitivity - #778
Merged
Merged
Conversation
The contributions of a score are quoted alone as often as the score: "transport, 0.74 kg CO2 eq of it". The flows and the activities a score breaks down into, by impact category or by single score, and the baseline of a sensitivity sweep now carry the same basis as the score, so such a figure keeps what says whether it can be set beside another. One function reads the basis off a solved score, the databases its chain reached; the score routes, the impacts tool and these all use it. The sensitivity tool scores the root's database alone, so its basis names that database alone. Wire revision 101.
The sensitivity tool now names its root-only solution once and reads both its cut-offs and its basis off it. The description of the sweep no longer says the basis names the root alone, since the REST route it also documents reads the dependencies. The score basis keeps its documentation, the new function now following it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #774 a score says what it rests on. Its contributions did not, yet they are quoted alone as often: "transport, 0.74 kg CO2 eq of the score", read from
get_contributing_activitieswithoutscore_activityfirst.Now
basiscomes with:baseline.basisover REST,basisfromcompute_sensitivity.What is left out, on purpose:
aggregateandcompare_activitiesgive inventory amounts with no method, and the reduced model is a formula, not a figure.solutionBasisreads the basis off a solved score, the databases its chain reached. The score routes andget_impactsnow use it too, instead of each spelling it out.Wire revision 102. pyvolca decodes
basisonContributingFlowsandContributingActivities;SensitivityResult.baselinealready did, being anLCIAResult.Checks:
cabal build all --ghc-options=-Werror,cabal test lca-tests, fourmolu, hlint (with the partials gate), and pytest on pyvolca.