Skip to content

Fix ingress dry run desired state#1073

Merged
cbusillo merged 1 commit into
mainfrom
ingress-dry-run-desired-state
May 31, 2026
Merged

Fix ingress dry run desired state#1073
cbusillo merged 1 commit into
mainfrom
ingress-dry-run-desired-state

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

Summary

  • keep ingress dry-run workflow under GitHub's 10-input workflow_dispatch limit
  • route all optional desired-state and request-control fields through route_options_json
  • preserve explicit false values for request controls and route toggles with jq has(...)

Tests

  • git diff --check
  • uv run --extra dev ruff check tests/test_product_onboarding.py --diff
  • uv run --extra dev ruff check tests/test_product_onboarding.py
  • uv run python -m unittest tests.test_product_onboarding
  • jq payload regression for explicit false controls/toggles and identity_access
  • docker run --rm -v "$PWD:/repo" -w /repo rhysd/actionlint:1.7.7 -config-file .github/actionlint.yaml .github/workflows/ingress-route-dry-run.yml

Refs #1065
Refs #1051

@cbusillo cbusillo merged commit 98f7ee3 into main May 31, 2026
12 checks passed
@cbusillo cbusillo deleted the ingress-dry-run-desired-state branch May 31, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant