Skip to content

Fix NPMplus compatibility env removal#1052

Merged
cbusillo merged 1 commit into
mainfrom
fix-npmplus-compat-dry-run
May 31, 2026
Merged

Fix NPMplus compatibility env removal#1052
cbusillo merged 1 commit into
mainfrom
fix-npmplus-compat-dry-run

Conversation

@cbusillo
Copy link
Copy Markdown
Owner

Summary

  • add explicit self-deploy oauth_env_removals so compatibility deploys can clear stale NPMplus env vars
  • have deploy-launchplane send NPMplus env removals when omit_npmplus_env is selected
  • fix ingress route dry-run defaults and route option passthrough, including rejecting unsupported option keys
  • document omit_npmplus_env as removal semantics

Refs #1043

Verification

  • uv run python -m unittest tests.test_product_onboarding tests.test_service.LaunchplaneServiceTests.test_self_deploy_endpoint_updates_target_env_and_triggers_dokploy tests.test_service.LaunchplaneServiceTests.test_self_deploy_endpoint_rejects_unknown_oauth_env_keys tests.test_service.LaunchplaneServiceTests.test_self_deploy_endpoint_removes_requested_oauth_env_keys tests.test_service.LaunchplaneServiceTests.test_self_deploy_endpoint_rejects_remove_and_update_same_oauth_env_key tests.test_docs_contracts tests.test_driver_descriptors tests.test_ingress_cli tests.test_npmplus
  • uv run --extra dev ruff check --diff control_plane/service.py tests/test_service.py tests/test_product_onboarding.py
  • uv run --extra dev ruff check control_plane/service.py tests/test_service.py tests/test_product_onboarding.py
  • uv run --extra dev mypy control_plane/service.py tests/test_service.py tests/test_product_onboarding.py
  • actionlint .github/workflows/deploy-launchplane.yml .github/workflows/ingress-route-dry-run.yml
  • jq smoke checks for ingress-route-dry-run route_options_json merge/reject behavior
  • uv run python -m unittest

@cbusillo cbusillo merged commit 2251119 into main May 31, 2026
12 checks passed
@cbusillo cbusillo deleted the fix-npmplus-compat-dry-run branch May 31, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant