Skip to content

Wire Auto Review lifecycle state into durable store #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiny-code-bot merged 1 commit into from
Jun 2, 2026
Merged

Wire Auto Review lifecycle state into durable store #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion code-rs/core/src/review_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ const RUNS_FILENAME: &str = "runs.json";
const OUTPUTS_DIR: &str = "outputs";
const SCHEMA_VERSION: u32 = 1;
const DEFAULT_MAX_RUNS: usize = 500;
const MAX_FINDING_DIGESTS: usize = 25;
const MAX_FINDING_DIGEST_TITLE_CHARS: usize = 160;

#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
Expand Down Expand Up @@ -135,6 +137,8 @@ pub struct AutoReviewRun {
pub finding_count: usize,
#[serde(default)]
pub finding_digests: Vec<AutoReviewFindingDigest>,
#[serde(default)]
pub omitted_finding_digest_count: usize,
#[serde(skip_serializing_if = "Option::is_none")]
pub summary_digest: Option<String>,
#[serde(skip_serializing_if = "Option::is_none")]
Expand Down Expand Up @@ -183,6 +187,7 @@ impl AutoReviewRun {
token_count: None,
finding_count: 0,
finding_digests: Vec::new(),
omitted_finding_digest_count: 0,
summary_digest: None,
superseded_by: None,
cancel_reason: None,
Expand Down Expand Up @@ -349,6 +354,10 @@ impl AutoReviewRunStore {
run.output_path = Some(output_path.clone());
run.finding_count = output.findings.len();
run.finding_digests = finding_digests(output);
run.omitted_finding_digest_count = output
.findings
.len()
.saturating_sub(run.finding_digests.len());
run.summary_digest = summarize(&output.overall_explanation, 240);
self.save()?;
Ok(output_path)
Expand Down Expand Up @@ -447,11 +456,12 @@ fn finding_digests(output: &ReviewOutputEvent) -> Vec<AutoReviewFindingDigest> {
output
.findings
.iter()
.take(MAX_FINDING_DIGESTS)
.enumerate()
.map(|(idx, finding)| AutoReviewFindingDigest {
finding_id: format!("f{}", idx + 1),
priority: finding.priority,
title: finding.title.clone(),
title: summarize(&finding.title, MAX_FINDING_DIGEST_TITLE_CHARS).unwrap_or_default(),
path: Some(finding.code_location.absolute_file_path.clone()),
line_start: Some(finding.code_location.line_range.start),
line_end: Some(finding.code_location.line_range.end),
Expand Down
2 changes: 1 addition & 1 deletion code-rs/exec/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ tokio = { workspace = true, features = [
tracing = { workspace = true, features = ["log"] }
tracing-subscriber = { workspace = true, features = ["env-filter"] }
once_cell = { workspace = true }
uuid = { workspace = true, features = ["v4"] }

[target.'cfg(unix)'.dependencies]
libc = "0.2"
Expand All @@ -56,4 +57,3 @@ libc = "0.2"
[dev-dependencies]
filetime = { workspace = true }
tempfile = { workspace = true }
uuid = { version = "1", features = ["v4"] }
Loading