test(java): add BouncyCastle digest edge-case coverage#419
Open
sachin9058 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
Contributor
Author
|
@san-zrl Hi! I continued investigating BouncyCastle edge cases and opened a follow-up PR adding explicit regression coverage for additional digest implementations already registered through Covered digests:
The focus is on improving explicit edge-case coverage and validating translation metadata without changing existing behavior. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds new edge-case regression tests for Bouncy Castle digest detection/translation, validating that specific Digest implementations are mapped into the expected MessageDigest model nodes.
Changes:
- Added a JUnit test (
BcDigestEdgeCasesTest) that verifies detection store values and translated node structure for multiple BC digests. - Added a Sonar test input file (
BcDigestEdgeCasesTestFile) containing “Noncompliant” markers for Whirlpool, Tiger, and RIPEMD-160 digests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| java/src/test/java/com/ibm/plugin/rules/detection/bc/signer/BcDigestEdgeCasesTest.java | New unit test asserting expected detection + translation outputs for several BC digest implementations. |
| java/src/test/files/rules/detection/bc/signer/BcDigestEdgeCasesTestFile.java | New verifier input file creating findings for Whirlpool/Tiger/RIPEMD160 digests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+87
| if (findingId == 0) { | ||
| /* | ||
| * Detection Store | ||
| */ | ||
| assertThat(detectionStore).isNotNull(); | ||
| assertThat(detectionStore.getDetectionValues()).hasSize(1); | ||
| assertThat(detectionStore.getDetectionValueContext()).isInstanceOf(DigestContext.class); | ||
| IValue<Tree> value0 = detectionStore.getDetectionValues().get(0); | ||
| assertThat(value0).isInstanceOf(ValueAction.class); | ||
| assertThat(value0.asString()).isEqualTo("WhirlpoolDigest"); | ||
|
|
||
| /* | ||
| * Translation | ||
| */ | ||
| assertThat(nodes).hasSize(1); | ||
|
|
||
| // MessageDigest | ||
| INode messageDigestNode = nodes.get(0); | ||
| assertThat(messageDigestNode.getKind()).isEqualTo(MessageDigest.class); | ||
| assertThat(messageDigestNode.getChildren()).hasSize(4); | ||
| assertThat(messageDigestNode.asString()).isEqualTo("Whirlpool"); | ||
|
|
||
| // Digest under MessageDigest | ||
| INode digestNode = messageDigestNode.getChildren().get(Digest.class); | ||
| assertThat(digestNode).isNotNull(); | ||
| assertThat(digestNode.getChildren()).isEmpty(); | ||
| assertThat(digestNode.asString()).isEqualTo("DIGEST"); |
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit regression coverage for additional BouncyCastle digest implementations that were already registered through
BcDigestsbut did not have dedicated tests.Added coverage
WhirlpoolDigestTigerDigestRIPEMD160DigestWhat changed
Added
BcDigestEdgeCasesTestFilewith digest instantiations and detection assertionsAdded
BcDigestEdgeCasesTestVerified detection and translation metadata for:
Validation
Notes
The digest implementations were already registered in
BcDigests, but explicit edge-case coverage for these variants was missing. This PR focuses only on regression coverage and does not modify existing translation behavior.Related: #31