Conversation
Both 'top' and 'bottom' positions iterated caption lines in reverse, which is only correct for 'bottom' (it anchors the last line and stacks upward). 'top' stacks downward, so the reversed iteration rendered the first line below the second. Only reverse for 'bottom' now. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printLineiterated the flattened caption lines in reverse for bothtopandbottom. Reversal is only correct forbottom, which anchors the last line and stacks upward;topstacks downward and needs source order.bottom;topandsourcenow both iterate in source order.Test plan
TestMultilineOrdertest renders a narrow first line and a wide second line, detects the two rendered text bands via the alpha channel, and asserts the first line is above the second — parametrized overtopandbottom.🤖 Generated with Claude Code