Fix test indentation and add print statement#732
Merged
kennethshsu merged 5 commits intomainfrom Apr 30, 2026
Merged
Conversation
Collaborator
Author
|
@genedan can you review this real quick? Our doc site is currently down because the doctests failed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
=======================================
Coverage 85.25% 85.25%
=======================================
Files 85 85
Lines 4952 4952
Branches 645 645
=======================================
Hits 4222 4222
Misses 521 521
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
genedan
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Relevant Github ticket(s)?
N/A
Note
Low Risk
Low risk: changes are limited to CI triggering and doctest invocation/output formatting, with no runtime/library logic modifications.
Overview
Stabilizes CI doctest runs and reduces workflow noise. The pytest GitHub Action is updated to run only on
pull_requestevents (push trigger commented out), and the doctest step now runsjb buildviauv run --directory docsto avoid relying on acd.Fixes doctest expectations for
load_sample. Theload_sampledocstring example now usesprint(tr)and updates the expected output formatting/values to match the currentTrianglestring representation. A minor typo in the PR template is corrected ("Relevent" -> "Relevant").Reviewed by Cursor Bugbot for commit 7200ec2. Bugbot is set up for automated code reviews on this repo. Configure here.