Skip to content

Fix test indentation and add print statement#732

Merged
kennethshsu merged 5 commits intomainfrom
doc_tests
Apr 30, 2026
Merged

Fix test indentation and add print statement#732
kennethshsu merged 5 commits intomainfrom
doc_tests

Conversation

@kennethshsu
Copy link
Copy Markdown
Collaborator

@kennethshsu kennethshsu commented Apr 30, 2026

What does this pull request do?

  • modify the doc test to use relative path instead
  • addressed the doc test failure on load_sample
  • limit the amount of CI runs, to run only on PR and commits subsequent to a PR

Relevant Github ticket(s)?

N/A


Note

Low Risk
Low risk: changes are limited to CI triggering and doctest invocation/output formatting, with no runtime/library logic modifications.

Overview
Stabilizes CI doctest runs and reduces workflow noise. The pytest GitHub Action is updated to run only on pull_request events (push trigger commented out), and the doctest step now runs jb build via uv run --directory docs to avoid relying on a cd.

Fixes doctest expectations for load_sample. The load_sample docstring example now uses print(tr) and updates the expected output formatting/values to match the current Triangle string representation. A minor typo in the PR template is corrected ("Relevent" -> "Relevant").

Reviewed by Cursor Bugbot for commit 7200ec2. Bugbot is set up for automated code reviews on this repo. Configure here.

@kennethshsu
Copy link
Copy Markdown
Collaborator Author

@genedan can you review this real quick? Our doc site is currently down because the doctests failed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.25%. Comparing base (ed1d5e5) to head (7200ec2).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          85       85           
  Lines        4952     4952           
  Branches      645      645           
=======================================
  Hits         4222     4222           
  Misses        521      521           
  Partials      209      209           
Flag Coverage Δ
unittests 85.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kennethshsu kennethshsu merged commit 3e83d14 into main Apr 30, 2026
9 checks passed
@kennethshsu kennethshsu deleted the doc_tests branch April 30, 2026 22:24
@henrydingliu henrydingliu mentioned this pull request May 1, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants