Repository navigation
feat(deploy): add SSH access to agent dev containers - #1449
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0aae4a562
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --cgroupns=host | ||
| --restart unless-stopped | ||
| --add-host host.docker.internal:host-gateway | ||
| --publish "${SSH_BIND_ADDRESS}::22" |
There was a problem hiding this comment.
Normalize IPv6 SSH bind addresses before publish
Using --ssh-bind-address with an IPv6 literal (for example ::1) currently produces --publish ::1::22, which Docker parses incorrectly because IPv6 host IPs must be bracketed in publish mappings (e.g. [::1]:...). This makes container startup fail for IPv6 bind-address use cases even though the flag is documented as accepting an IP address. Consider normalizing IPv6 values (or requiring bracketed input) before composing the --publish argument.
Useful? React with 👍 / 👎.
Summary
Validation