Skip to content

fix(dev): connect agent containers to dev network - #1431

Closed
simonjcarr wants to merge 4 commits into
mainfrom
fix/agent-container-network-v2
Closed

fix(dev): connect agent containers to dev network#1431
simonjcarr wants to merge 4 commits into
mainfrom
fix/agent-container-network-v2

Conversation

@simonjcarr

@simonjcarr simonjcarr commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a systemd-capable local Ubuntu agent test container helper
  • seed dev-stack agent container defaults in .dev/dev.env
  • connect local agent test containers to the dev-stack Docker network using internal service names
  • make installer bootstrap failures fail loudly instead of being hidden by a pipe
  • document the intentional root/systemd image exception and add a healthcheck

Validation

  • bash -n dev-stack.sh
  • bash -n deploy/scripts/create-agent-dev-container.sh
  • bash -n deploy/scripts/test-dev-stack.sh
  • bash -n deploy/scripts/test-create-agent-dev-container.sh
  • deploy/scripts/test-dev-stack.sh
  • deploy/scripts/test-create-agent-dev-container.sh

Replaces #1430.

@simonjcarr simonjcarr mentioned this pull request May 15, 2026
Closed
github-advanced-security[bot]
github-advanced-security Bot found potential problems May 15, 2026
View reviewed changes
Comment thread deploy/docker/agent-dev-container/Dockerfile
@@ -0,0 +1,23 @@
# trivy:ignore:DS-0002
@simonjcarr simonjcarr mentioned this pull request May 15, 2026
Merged
@simonjcarr

simonjcarr commented May 15, 2026

Copy link
Copy Markdown
Collaborator Author

Closing in favor of replacement PR #1432, created from a fresh worktree after the Trivy code-scanning failure persisted.

@simonjcarr simonjcarr closed this May 15, 2026
@ct-simon-carr
ct-simon-carr deleted the fix/agent-container-network-v2 branch May 15, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simonjcarr @github-advanced-security @codex