Repository navigation
test: run skill evals with vitest - #51
Merged
Merged
Conversation
✅ Deploy Preview for fullstack-promptable-app-example ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fullstack-promptable-prompt-first ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fullstack-promptable-agentic ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The migration is consistent, references are updated, and filtering and fixture coverage are preserved.
Review effort: Balanced
Findings: None
What changed in this PR
Migrates static skill evaluations from a standalone Node runner to grouped Vitest tests backed by a typed TypeScript catalog.
Changes:
- Converts the skill-evaluation catalog to TypeScript.
- Groups evaluations by skill and improves fixture helpers.
- Updates scripts and documentation for the new Vitest workflow.
| File | Description |
|---|---|
scripts/skills/skillEvals.ts |
Defines typed skill evaluations and results. |
scripts/skills/skillEvals.test.ts |
Runs evaluations as grouped Vitest cases. |
package.json |
Points the evaluation script at the new test file. |
skills/evals/README.md |
Documents grouping and filtering behavior. |
skills/AUTHORING.md |
References the new evaluation catalog. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Replace the node runner with one Vitest case per app-to-skill check, including the choose-a-UX check from main. Co-authored-by: carlosvin <carlosvin@gmail.com>
cursor
Bot
force-pushed
the
cursor/vitest-skill-evals-3851
branch
from
October 7, 2026 07:02
1648d1c to
6592be8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skill evals no longer have a separate Node runner.
scripts/skills/runSkillEvals.mjsis gone. The same static app↔skill checks live inscripts/skills/skillEvals.tsand run as individual Vitest cases inscripts/skills/skillEvals.test.ts.Merged
main, including the choose-a-UX check (choose-ux-asks-when-unclear), into that TypeScript catalog.pnpm test:skill-evalsisvitest run scripts/skills/skillEvals.test.ts. Filter by skill or check id with Vitest's-tflag, for examplepnpm test:skill-evals -- -t observability-and-env.Test plan
pnpm test:skill-evals— 35 passed after mergingmain