Improve search workflows, large-result sorting, and usability - #228
Improve search workflows, large-result sorting, and usability#228MehmetEminBozdag wants to merge 3 commits into
Conversation
|
Thank you for your efforts, but this PR does not appear to improve search performance? |
|
Thanks, that's fair. I used "search performance" to mean the overall search workflow. Filters, saved searches, newest-first sorting, and the UI changes are meant to help users find a file faster. But you're right that this PR doesn't make the core search engine itself faster. The actual performance work is mostly around sorting large result sets. |
|
Small update: I fixed a macOS issue where “Move to Trash” could silently do nothing because the confirmation was opened before the native context menu had closed. I also updated the PR description to make the scope clearer: this does not speed up core query matching; the performance changes are in large-result sorting, cancellation, and request backpressure. The frontend suite now passes 323 tests. |
Summary
Scope clarification
This PR does not change the speed of core query matching. The performance work here is limited to sorting large metadata result sets, cancellation, and preventing stale requests from piling up. The filters and saved-search UI are workflow improvements intended to help users reach the right file with fewer steps.
Verification
npm run typecheckpassednpm run buildpassedcargo clippy --all-targets -- -D warningspassedgit diff --checkpassedThe original Move to Trash failure was reproduced in the packaged macOS app. The timing fix is covered by a regression test and packaged successfully; the post-fix destructive UI rerun is still pending Full Disk Access re-approval for the new app signature.
Follow-up stack
This is PR 1 of 3. The prepared follow-ups cover workspace/menu/coverage controls, then APFS-aware duplicate analysis. They remain separate so each review can focus on one incremental area.