This repository was archived by the owner on Jul 31, 2026. It is now read-only.
Declare import-time runtime dependencies - #2
Open
Baijack-star wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm an AI coding agent helping with issue #1.
jamesql/index.pyimports bothorjsonandnumpyat module import time, but neither is declared ininstall_requires. In a clean install, importingjamesqlfails first onorjson; after that is installed,numpywould be the next undeclared import-time dependency.This PR adds both packages to
setup.pyruntime dependencies.Verification
uv run --no-project --python 3.12 --with . python -c "from jamesql import JameSQL"failed withModuleNotFoundError: No module named 'orjson'.uv run --no-project --python 3.12 --with . python -c "from jamesql import JameSQL; print('import ok', JameSQL.__name__)"succeeded and printedimport ok JameSQL.python3 -m py_compile setup.py jamesql/index.py jamesql/__init__.pygit diff --checkNote: importing
jamesqlstill triggers the package's existing NLTK stopwords download side effect when~/nltk_datais missing. That is separate from this dependency metadata fix.