test: use native fetch in cds oq#449
Open
sjvans wants to merge 1 commit into
Open
Conversation
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The PR makes a one-line env-variable change to enable native fetch in a single test file, but the mutation is applied at module-load time with no teardown, meaning the environment variable leaks into any other test files that share the same process. This should be addressed by saving and restoring the original value in beforeAll/afterAll.
PR Bot Information
Version: 1.26.14
- File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - Correlation ID:
c55e71a0-76e7-11f1-8989-8b103d27310e - LLM:
anthropic--claude-4.6-sonnet
Contributor
There was a problem hiding this comment.
The PR is a minimal, focused change that correctly enables native fetch before CDS is required. One issue flagged: the global process.env mutation should be cleaned up after the test suite to prevent leaking into other test files sharing the same Jest worker.
PR Bot Information
Version: 1.26.14
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
d45291a0-76e7-11f1-8064-d0bc03aba188 - File Content Strategy: Full file content
- Event Trigger:
pull_request.ready_for_review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in cds oq, we have cloud-sdk → it is preferred over native fetch
the test added in #425 only works when native fetch is used