ci: drop the setup-node registry step from the release workflow - #41
Conversation
Trusted publishing needs no .npmrc. The step wrote one with an
_authToken=${NODE_AUTH_TOKEN} placeholder that no longer expands since
the token was removed, so any OIDC failure fell back to a bogus
credential and surfaced as a misleading E404 instead of an auth error.
Node already comes from setup-vp.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release workflow removes the extra ChangesRelease workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized workflow cleanup removes the obsolete npm registry configuration step; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description clearly explains what changed, why the registry step was harmful, and the effect on trusted publishing. It does not include the template's Testing section, but the main review context is complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Trusted publishing needs no
.npmrc, and this step was writing a harmful one.When #33 removed
NODE_AUTH_TOKENfrom the publish env, theSetup npm registrystep kept writing_authToken=${NODE_AUTH_TOKEN}into the runner's.npmrcwith nothing to expand it. npm treats the unexpanded placeholder as a real (bogus) credential, so when the OIDC exchange failed — the trusted publisher was registered underrelease.yamlinstead ofrelease.yml— the publish surfaced as a misleadingE404 Not Found - PUTinstead of an auth error. That's what broke the 0.3.0 release run.The registry-side filename is fixed and 0.3.0 republished from the re-run, so this is cleanup: without the step, an OIDC failure fails loudly as an auth error instead of falling back to garbage. Node still comes from
setup-vp, which is where the runner's v24 (npm 11.17, OIDC-capable) already came from. The changesets trusted-publishing guide uses neitherregistry-urlnorNODE_AUTH_TOKEN.🤖 Generated with Claude Code
Summary by CodeRabbit