Skip to content

ci: drop the setup-node registry step from the release workflow - #41

Merged
hunterbecton merged 1 commit into
mainfrom
hunter/release-drop-setup-node
Aug 26, 2026
Merged

ci: drop the setup-node registry step from the release workflow#41
hunterbecton merged 1 commit into
mainfrom
hunter/release-drop-setup-node

Conversation

@hunterbecton

@hunterbecton hunterbecton commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Trusted publishing needs no .npmrc, and this step was writing a harmful one.

When #33 removed NODE_AUTH_TOKEN from the publish env, the Setup npm registry step kept writing _authToken=${NODE_AUTH_TOKEN} into the runner's .npmrc with nothing to expand it. npm treats the unexpanded placeholder as a real (bogus) credential, so when the OIDC exchange failed — the trusted publisher was registered under release.yaml instead of release.yml — the publish surfaced as a misleading E404 Not Found - PUT instead of an auth error. That's what broke the 0.3.0 release run.

The registry-side filename is fixed and 0.3.0 republished from the re-run, so this is cleanup: without the step, an OIDC failure fails loudly as an auth error instead of falling back to garbage. Node still comes from setup-vp, which is where the runner's v24 (npm 11.17, OIDC-capable) already came from. The changesets trusted-publishing guide uses neither registry-url nor NODE_AUTH_TOKEN.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Simplified the release publishing workflow by removing redundant npm registry configuration.
    • Release publishing continues to use the existing registry setup.

Trusted publishing needs no .npmrc. The step wrote one with an
_authToken=${NODE_AUTH_TOKEN} placeholder that no longer expands since
the token was removed, so any OIDC failure fell back to a bogus
credential and surfaced as a misleading E404 instead of an auth error.
Node already comes from setup-vp.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f24aa8bd-1646-43a9-b980-bd02f0c1a6c0

📥 Commits

Reviewing files that changed from the base of the PR and between 49ea052 and 94673c4.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/release.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow removes the extra actions/setup-node@v7 step that configured the npm registry. Publishing now uses the registry configuration already present in the workflow.

Changes

Release workflow

Layer / File(s) Summary
Remove duplicate registry setup
.github/workflows/release.yml
Removes the npm registry setup step from the release job.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 94673

This localized workflow cleanup removes the obsolete npm registry configuration step; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of the setup-node registry step from the release workflow.
Description check ✅ Passed The description clearly explains what changed, why the registry step was harmful, and the effect on trusted publishing. It does not include the template's Testing section, but the main review context …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains what changed, why the registry step was harmful, and the effect on trusted publishing. It does not include the template's Testing section, but the main review context is complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hunter/release-drop-setup-node

Comment @coderabbitai help to get the list of available commands.

@hunterbecton
hunterbecton merged commit 19a9dcb into main Aug 26, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant