Conversation
…L byte The literal NUL in the source made grep and ripgrep classify the whole 2011-line iOS driver as binary, so the file was invisible to a normal search. The escape produces the same runtime string. Closes #141 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018HHP7Th9NqWfhexmp4V9Pf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
src/drivers/ios/index.ts:594held a literal NUL character in the source text. That one byte madegrepandripgrepclassify the whole 2011-line iOS driver as binary, so the file was invisible to a normal search. The\0escape produces the same runtime string, so the download-lock key is unchanged.The guard test from triage comes with it, enumerating
git ls-filesso it covers every tracked file rather than one directory.readFileSync("src/drivers/ios/index.ts").indexOf(0)returns-1; it was27650.rg -c advisor src/drivers/ios/index.tsprints2instead ofbinary file matches.tracked files > contain no raw NUL byte, so grep and ripgrep can search themred withsrc/drivers/ios/index.ts:594 (byte 27650).pnpm check. Typecheck, oxlint, oxfmt and the unit suite are clean. Two e2e files failed on a stray-daemon teardown under full-suite load and pass in isolation on this branch; the same files pass onmainin isolation too.Written by an agent.
Generated by Claude Code