fix: require patched Joi version - #724
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
thymikee
force-pushed
the
fix/joi-prototype-pollution
branch
from
August 21, 2026 17:58
c051588 to
f562feb
Compare
thymikee
marked this pull request as ready for review
August 21, 2026 17:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require Joi 17.13.6 or newer in
@rock-js/configto prevent prototype pollution through localized validation messages.The reported PoC reproduces with Joi 17.13.3 and no longer reproduces with 17.13.6, which contains the upstream
fix: prevent messages proto injectionpatch. This also adds a focused regression test and a patch changeset.Upstream fix: hapijs/joi@8d0b808f3e87
Validation
./node_modules/.bin/vitest run packages/config/src/lib/__tests__/schema.test.ts./node_modules/.bin/eslint packages/config/src/lib/__tests__/schema.test.tsgit diff --check