fix: Report active context on device timeout#137
Closed
mrousavy wants to merge 1 commit into
Closed
Conversation
|
@mrousavy is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
08617c0 to
227fa59
Compare
Author
|
sorry this is an AI generated fix, no idea if this is even good stuff or if this should be closed immediately |
Contributor
|
Closing as superseded by #138. The useful suite/file context gap from this PR is now covered there via runtime-owned suite hook timeouts, pending promise diagnostics, and app restart after timeout cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Harness bridge RPC times out with
DeviceNotRespondingError, include the last started Harness context in the Jest file failure message. The context can be the active test, the active suite before a test starts, or the active file if no suite has started yet.This does not change timeout values, retry behavior, app lifecycle, or test execution. It only preserves context that Harness already receives through file/suite/test runner events.
Why
For file-level bridge timeouts, Jest currently reports only that the device did not respond. If the test file contains many native operations or hangs in
beforeAll, CI cannot tell which part of the file was active when the device stopped responding.Verification
PATH="$HOME/.nvm/versions/node/v20.19.4/bin:$PATH" corepack pnpm vitest --config vite.config.ts run src/__tests__/execute-run.test.tsNote: the repo-wide pre-push hook currently fails locally while processing the Nx project graph, before running this patch-specific test. The focused Jest runner test passes.