Repository navigation
Conversation
The v6 getting-started and theming guides link to src/styles/themes/v3/LightTheme.tsx, which no longer exists on main. Point them at src/theme/schemes/LightTheme.tsx. Also correct spelling in the v5 guides: platfrom, Additionaly, oficially, follwing.
|
Found potential problems with the pull request:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The v6 guides link to the default MD3 theme at
src/styles/themes/v3/LightTheme.tsx, which no longer exists onmain, so both links 404:docs/6.x/docs/guides/getting-started.mdxdocs/6.x/docs/guides/theming.mdxThey now point at
src/theme/schemes/LightTheme.tsx, where the file lives today.Also fixes a few typos in the v5 guides:
fonts.md: "platfrom" → "platform"getting-started.md: "Additionaly" → "Additionally"migration-guide-to-5.0.md: "oficially" → "officially", "follwing" → "following", "Additionaly" → "Additionally" (twice)The v5 guides contain the same
src/styles/themes/...links. I left those alone because the right target there is a v5 ref rather thanmain; happy to update them here if you have a preferred one.Related issue
None; docs only.
Screenshots / Videos
N/A
Test plan
Open the two "default theme" links in the v6 getting-started and theming guides and confirm they resolve to
LightTheme.tsx.