Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The cache key changes address the cross-variant restore issue, with no unresolved review comments.
No open issues 🎉
What changed in this PR
This pull request isolates CocoaPods and SwiftPM iOS CI ccache namespaces so each job restores only its own cache.
Changes:
- Adds a
CACHE_VARIANTbased on thespmworkflow input. - Uses variant-specific ccache and restore-key prefixes.
| File | Description |
|---|---|
.github/workflows/ios.yml |
Separates ccache namespaces for CocoaPods and SwiftPM iOS builds. |
Review effort: Lite
🟢 e2e: 21 passedAll 21 tests in 12 files
e2e 0.21.0 · 6m 31s · ios · run artifacts |
krozniata
marked this pull request as ready for review
October 26, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the iOS CI ccache restore key.
ccache-ios-also matchedccache-ios-spm-…, so the CocoaPods job could restore the SwiftPM job's ccache and get 0 hitsThe keys are now
ccache-ios-pods-…andccache-ios-spm-…, so neither matches the other.Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md