Repository navigation
fix(create-react-native-library): keep generated gitignore in example apps - #952
Merged
satya164 merged 2 commits intoOct 21, 2026
Merged
Conversation
satya164
requested changes
Sep 8, 2026
dcavalcante
force-pushed
the
fix/test-app-ignore-artifacts
branch
from
September 9, 2026 12:35
eb10dee to
2491285
Compare
Contributor
Author
|
Updated to preserve react-native-test-app’s generated |
Contributor
Author
|
hey @satya164 I updated this to preserve the test app’s generated .gitignore as suggested. The old CI runs are still marked failed, but their logs/jobs have expired. When you have a chance, can you please take another look and rerun the checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
create-react-native-librarygenerates the example app with@react-native-community/cli,react-native-test-apporcreate-expo-app, then removes the generated.gitignore. That loses the app-specific rules for generated local artifacts, such as.xcode.envand*.xcworkspace/for the test app.Fix
Keep the generated
.gitignorefor all example types. For Expo examples of native libraries, append theandroid/andios/rules instead of overwriting the file, so the Expo rules stay. Older Expo SDK templates (e.g. SDK 52) don't ignore the native folders, so the rules are still needed.Validation
example/.gitignore..xcode.envand*.xcworkspace/rules.git diff --check.