chore: drop the stale planned-operations closure approval - #2373
Open
thymikee wants to merge 1 commit into
Open
Conversation
The APPROVED_OVER_CEILING row for packages/command-registry/src/planned-operations.ts was consumed by #2329. Now that main carries the entry, the no-growth rule governs it and the row can no longer change any verdict, so the "no row is stale" probe fails on main and on every PR based on it. Remove the row, as the probe instructs.
Size Report
Startup median (7 runs, lower is better):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/__tests__/eager-closure-budgets.test.ts › no APPROVED_OVER_CEILING row is stalefails on main ate7a5b8b622and on every PR based on it (for example #2325, #2372, #2363).The
APPROVED_OVER_CEILINGrow forpackages/command-registry/src/planned-operations.tswas consumed by #2329. Now that main carries that entry, the no-growth rule governs it and nothing reads the row again, so the probe reports it stale and asks for its removal. This does exactly that: one row deleted, no budget or ceiling changed.Validation
scripts/__tests__/eager-closure-budgets.test.ts: 478/478 green locally againstorigin/main;tsc -p tsconfig.jsonclean.