test(android-e2e): read the logcat tail for rotation evidence - #2359
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
|
This was referenced Sep 6, 2026
Member
Author
|
The logcat-tail change looks good at dcb60a5. The reported artifact contains the rotation decisions, and the existing timeout and output caps remain intact. The remaining merge blocker is the failing Android smoke semantic-canary step. |
The first CI failure with the evidence hook (PR #2356, run 34029660070) lost its logcat section: dumping the emulator's whole 2MB buffer took longer than the 5s per-probe bound on the loaded host. The probe now reads the last 4000 lines, which holds the rotation decisions of the last minutes and returns well inside the bound.
thymikee
force-pushed
the
claude/android-e2e-logcat-tail
branch
from
September 7, 2026 06:04
dcb60a5 to
dd2d455
Compare
Member
Author
|
The logcat-tail change remains clean at dd2d455. The rebase leaves the reviewed code unchanged, and all checks are green. Ready for human review. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first CI failure carrying the rotation evidence (PR #2356, https://github.com/callstack/agent-device/actions/runs/34029660070) lost its logcat section:
(failed: Command failed: adb -s emulator-5554 logcat -d -v time), the 5s per-probe bound killing a full 2MB buffer dump on the loaded host. The probe now readslogcat -d -v time -t 4000, which holds the rotation decisions of the last minutes and returns well inside the bound (a local 2MB dump takes under a second; the tail is 290KB).The settings and display sections of that file were intact and show the device in portrait at that failure, which is a different failure from the alert-canary one and is being handled on #2356.