Repository navigation
Fix 5.4 docs for afterSaveCommit/afterDeleteCommit, document Connection.afterCommit event - #8349
Open
dereuromark wants to merge 1 commit into
Open
dereuromark wants to merge 1 commit into
dereuromark wants to merge 1 commit into
Conversation
The deferred dispatch of Model.afterSaveCommit and Model.afterDeleteCommit inside an outer transaction was reverted before 5.4.0 shipped, but the docs still described it. Restore the 5.3 wording (the events are not triggered when a transaction was started before save/delete), drop the "Changed in 5.4.0" notes and the migration guide bullet. Document the Connection.afterCommit event, which is the supported hook for reacting to the outermost commit, and link it from both events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8348.
The deferred dispatch of
Model.afterSaveCommitandModel.afterDeleteCommitinside an outer transaction (cakephp/cakephp#19383) was reverted in cakephp/cakephp#19417 before 5.4.0 shipped. The docs still described it as a 5.4 change.appendices/5-4-migration-guide.md: removed the behavior-change bullet and added theConnection.afterCommitevent under new Database features.orm/table-objects.md: both events are back to the 5.3 wording (not triggered when a transaction was started beforesave()/delete()), without the "Changed in 5.4.0" boxes. Each now links to the connection-level hooks.orm/database-basics.md: new "Connection.afterCommit Event" section for the event added in Add Connection.afterCommit event for outermost-commit hooks cakephp#19429.The Japanese pages never received the deferral text, so they are unchanged.