Repository navigation
fix: missing notification icons for Chromium-based applications - #2008
Open
garincharles7-code wants to merge 3 commits into
Open
garincharles7-code wants to merge 3 commits into
garincharles7-code wants to merge 3 commits into
Conversation
garincharles7-code
marked this pull request as draft
September 14, 2026 02:35
garincharles7-code
marked this pull request as ready for review
September 14, 2026 06:07
garincharles7-code
marked this pull request as draft
September 14, 2026 06:50
garincharles7-code
force-pushed
the
fix-chromium-notification-icons
branch
from
September 14, 2026 08:44
bd72492 to
c935366
Compare
garincharles7-code
force-pushed
the
fix-chromium-notification-icons
branch
3 times, most recently
from
September 14, 2026 11:22
f68742a to
f3f8221
Compare
…o caelestia cache
garincharles7-code
force-pushed
the
fix-chromium-notification-icons
branch
from
September 14, 2026 11:45
e57cf17 to
e3b242b
Compare
garincharles7-code
marked this pull request as ready for review
September 14, 2026 11:53
garincharles7-code
force-pushed
the
fix-chromium-notification-icons
branch
from
September 14, 2026 13:08
8a5ca5f to
d851167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1904
Issue
As the documented reason in #1904, it is discovered that Google Chrome is not the only application that has a behavior where it clears its image directory completely in /tmp/ folder upon being completely closed. It is tested that Chromium browsers like Opera, Microsoft Edge and Brave shares the same behavior. Because of this, the sidebar and lock notifications renders a fallback black and magenta tile.
Main Evidence from different tested Chromium-based Browers/Applications:
recording_20260913_18-31-20.mp4
Evidence from another user (@Pix3lM0on):

Proposed Solution
Before even the image variable is initialized, it must be first checked if the appName is either Google Chrome, Brave, Microsoft Edge, Opera and etc. (this can scale but its only tested on these 4 main browsers). If the appName matches with these, that means it would not go into the normal process of using the original path to be later initialized by Notifs.qml to notifs.json, but instead redirect the path and move the file to the ~/.cache/caelestia/chromiumicons/(appName).png so that other process like lock and sidebar notifications would still have the cache to render the icons they needed.
After applying the solution:
recording_20260913_18-34-49.mp4
Extra Fixes
it also includes the fix provided by #1678 for the missing appIcon for these applications during pop up previews, sidebar notifications, and lock notifications.