Skip to content

fix(services,notifs): harden json parsing, null safety guards, and toast previews - #2004

Open
Swastik36 wants to merge 1 commit into
caelestia-dots:mainfrom
Swastik36:fix/shell-hardening
Open

Swastik36 wants to merge 1 commit into
caelestia-dots:mainfrom
Swastik36:fix/shell-hardening

Conversation

@Swastik36

Copy link
Copy Markdown

Summary

Fixes several runtime errors, null dereferences, and uncaught exceptions across notifications, toasts, weather, and system icons.

Changes

  • Services (Notifs & Weather): Added safe JSON parsing and fallback error handling in Notifs.qml and Weather.qml to prevent uncaught exceptions on corrupted storage or bad API responses.
  • Toasts: Added null checks on item.modelData and Toaster.toasts[i] in Toasts.qml to avoid TypeError during toast dismissals.
  • Icons & IPC: Added type and null guards for icon matchers and safe navigation on Hyprland workspace objects in NotifData.qml and Hypr.qml.

@Swastik36
Swastik36 force-pushed the fix/shell-hardening branch 4 times, most recently from 8e1e612 to 95db4f3 Compare September 13, 2026 09:03
@dxnnv dxnnv added the fix Fixes a bug or error label Sep 14, 2026
…ast previews

- utils/Icons.qml: integrate with matchIconRuleList, add safe try/catch regex guards and type validation
- services/Weather.qml: adopt Units.twelveHourClock, add null safety for sunrise/sunset, guard geocoding recursion
- services/Notifs.qml: harden JSON parsing and quarantine corrupted notifications, add Notifs.send helper
- modules/utilities/toasts/Toasts.qml: preserve fullscreen toast config with identity-based ranking
- modules/notifications/Notification.qml: clean up redundant chaining and guard against null actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes a bug or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants