fix(test): correct dynamic config path in docker-compose#137
Open
abhishekj720 wants to merge 1 commit into
Open
fix(test): correct dynamic config path in docker-compose#137abhishekj720 wants to merge 1 commit into
abhishekj720 wants to merge 1 commit into
Conversation
The ubercadence/server image places dynamic config under /etc/cadence/dynamicconfig/, so DYNAMIC_CONFIG_FILE_PATH must be dynamicconfig/development.yaml — not config/dynamicconfig/development.yaml. The wrong path caused the config file (including worker.enableScheduler=true) to silently not load, making all schedule API calls time out with DEADLINE_EXCEEDED. Verified by running the full schedule_sample demo locally after the fix. Signed-off-by: abhishek.jha <abhishek.jha@uber.com>
Code Review ✅ ApprovedUpdates the docker-compose dynamic config path to align with the server image structure, resolving scheduler timeout issues. Redundant environment overrides were removed as the updated configuration file now correctly enables the scheduler. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ubercadence/serverimage places dynamic config files under/etc/cadence/dynamicconfig/, but the docker-composeDYNAMIC_CONFIG_FILE_PATHwas set toconfig/dynamicconfig/development.yaml. That path does not exist in the image so the config file was silently ignored meaningworker.enableScheduler: truenever loaded and all schedule API calls timed out withDEADLINE_EXCEEDED.Fix: set the path to
dynamicconfig/development.yaml, which resolves correctly to/etc/cadence/dynamicconfig/development.yamlinside the container.Also removes the now-redundant
CADENCE_OVERRIDE_DYNAMIC_CONFIG=system.enableSchedules:trueline, the bundleddevelopment.yamlalready setsworker.enableScheduler: true.How it was found
Running
samples/schedule_sample.py demoagainst the Docker stack:create_schedulesucceeded butdescribe_schedulealways returnedDEADLINE_EXCEEDED. Confirmed by runningfindinside the container the file was atdynamicconfig/development.yaml, notconfig/dynamicconfig/development.yaml. After the fix, the full demo ran end-to-end successfully.Test plan
docker compose up -d→uv run python samples/schedule_sample.py democompletes all steps without error