Docs, pinned helm-ls cache, editing queries, and CI - #33
Merged
Merged
Conversation
cabrinha
marked this pull request as ready for review
August 26, 2026 23:37
README still told people to install helm-ls first, which has not been true since the auto-download path landed. yaml-language-server remains required for full Kubernetes schema LSP. Recommended file_types now match the Zed Helm docs: templates, helmfile.d, and values*.yaml. Chart.yaml stays YAML. Globs do not belong in path_suffixes.
A cached helm-ls build was only used when latest_github_release failed, so every Zed restart hit GitHub. Pin v0.5.4, return that binary when it is already on disk, and only delete other helm_ls_* version dirs after a download so languages/ and grammars/ are not wiped. The pin and cleanup rules live in a host-testable module.
Everyday editing was missing tree-sitter indent and bracket matching
beyond config.toml auto-close. Indent if/range/with/define/block, outdent
end/else, and treat named templates as textobjects. Also outdent {{ end }}
lines via decrease_indent_patterns.
Run cargo test, a wasm32-wasip1 build, and tree-sitter parse/query checks against a small example chart. No extra secrets. Catches helm-ls pin regressions and highlight/indent query breakage.
Zed rejected mixed @content/@injection.content and invalid backtick brackets even though tree-sitter query compiled them. Fail CI on those load errors, using the same capture-name rules as the speed/accuracy branch. Also lock the tree-sitter-go-template SHA in tests/grammar-pin.sha to the extension.toml pin, clone that commit, and regenerate the helm dialect the way the upstream grammar CI does so generated parser files cannot drift silently.
Copy the check_extension steps from zed-industries/zed extension_tests.yml: wget the cached zed-extension CLI and package with --source-dir / --scratch-dir / --output-dir, and run ts_query_ls format --check languages from the ribru17/ts_query_ls v3.15.1 release. Format the Helm query files so that check passes. Grammar pin and Zed query-load jobs stay as they are.
cursor
Bot
force-pushed
the
cursor/helm-docs-pin-queries-ci-b2d5
branch
from
August 27, 2026 00:37
5bcbd08 to
b404421
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto
mainafter #32 merged. This PR no longer fights that work.From #32 (already on main, kept)
Vendored helm lexer (
{}plus rest of line plus trailing newline), YAML injected per(text)node with only@content(nocombined, no dual@content/@injection.content), file detection (.tpl/ helmfile suffixes), helm-ls settings wrapping,brackets.scmwithout the backtick rule, andscripts/check-grammar.sh.From #33
README/docs (pinned helm-ls auto-download, yaml-language-server for full LSP), helm-ls pin+cache (
src/binary.rs, skip GitHub when the pinned binary is on disk),indents.scm/textobjects.scm, and CI: grammar-diff gate, Zed-style query load,zed-extensionpackage,ts_query_ls format --check languages.zed_extension_apistays at 0.5.0.Conflicts resolved on rebase
lsp_settings/ wrap /YAMLLS_PATH.path_suffixesandfirst_line_pattern, plus Docs, pinned helm-ls cache, editing queries, and CI #33decrease_indent_patterns.ts_query_lsformat.combined, then format.tests/grammar-pin.shanow matches the vendored pind4a62d1. Query scripts compile against localvendor/tree-sitter-helm. Combined injection is rejected by bothcheck-grammar.shandcheck-zed-queries.sh.How I tested
cargo test(15 tests: pin/cache + helm-ls settings wrap)cargo build --target wasm32-wasip1 --releasebash scripts/check-queries.shbash scripts/check-grammar.shbash scripts/check-grammar-pin.shbash scripts/check-zed-queries.sh(fails dual@content, combined injection, and backtick brackets)ts_query_ls format --check languages