Fix relaxed resolver paths with missing intermediate nodes - #282
Open
Gonghan-Princess wants to merge 1 commit into
Open
Gonghan-Princess wants to merge 1 commit into
Gonghan-Princess wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a path contains a missing intermediate child,
Resolver(relax=True).get()currently continues traversingNoneand raisesAttributeError. For example, bothmissing/childandmissing/..fail instead of returningNone.Return immediately when child resolution fails. Regression tests cover relative and absolute paths, a missing child below an existing node, custom separators, and case-insensitive matching. They also verify strict mode preserves
ChildResolverErrorand its missing-child context.Fixes #264.
Validation
Tested on Windows with Python 3.12.10 and the repository's previously frozen development environment:
AttributeError.pytest -vvsuite: 250 passed, 1 skipped; 98% total coverage. The skipped image-export test requires Graphviz, which is unavailable locally. Reference fixtures were read as their exact committed LF bytes for the test run to avoid Windows checkout conversion, then restored to normal checkout state.pre-commit run --all-files: passed all applicable hooks.mypy src: passed for all 33 source files.git diff --check: passed.AI assistance
OpenAI Codex assisted with diagnosis, implementation, tests, and this description. No third-party code or assets were introduced; the changes are submitted under the project's existing license.