Backend: avoid recursion; use explicit stack with iteration instead. - #23
Merged
Merged
Conversation
This was overflowing the native stack on some very (very) large function bodies. Note that the main lowering loop needs to be made explicitly iterative as well; the auto-derived `Drop` impl was too recursive as well (!).
Merged
fitzgen
approved these changes
Oct 1, 2026
fitzgen
left a comment
fitzgen
left a comment
Member
There was a problem hiding this comment.
One of my favorite little problems to solve
gkgoat1
pushed a commit
to gkgoat1/waffle
that referenced
this pull request
Oct 3, 2026
Includes: - bytecodealliance#22: completeness fix for `resolve_aliases` pass. - bytecodealliance#23: scalability improvement in backend for very large functions (which result in very deeply-nested Wasm structured control flow trees). - bytecodealliance#24: make the empty-blocks pass public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was overflowing the native stack on some very (very) large function bodies.
Note that the main lowering loop needs to be made explicitly iterative as well; the auto-derived
Dropimpl was too recursive as well (!).