Skip to content

Resolve ByteArrayMemory volatile access support once #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreas-karlsson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolve ByteArrayMemory volatile access support once #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions runtime/src/main/java/run/endive/runtime/ByteArrayMemory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,25 @@ public final class ByteArrayMemory implements Memory {
private static final boolean HAS_INT_ATOMICS = hasFullAtomicSupport(INT_ARR_HANDLE);
private static final boolean HAS_LONG_ATOMICS = hasFullAtomicSupport(LONG_ARR_HANDLE);

// Resolved once: isAccessModeSupported is expensive when the mode is unsupported, as it is
// for byte array views on recent JDKs (it throws and catches an error internally).
private static final boolean HAS_BYTE_VOLATILE_GET =
BYTE_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE);
private static final boolean HAS_SHORT_VOLATILE_GET =
SHORT_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE);
private static final boolean HAS_INT_VOLATILE_GET =
INT_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE);
private static final boolean HAS_LONG_VOLATILE_GET =
LONG_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE);
private static final boolean HAS_BYTE_VOLATILE_SET =
BYTE_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE);
private static final boolean HAS_SHORT_VOLATILE_SET =
SHORT_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE);
private static final boolean HAS_INT_VOLATILE_SET =
INT_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE);
private static final boolean HAS_LONG_VOLATILE_SET =
LONG_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE);

// Page addressing constants
private static final int PAGE_SHIFT = 16; // PAGE_SIZE = 65536 = 2^16
private static final int PAGE_MASK = PAGE_SIZE - 1;
Expand Down Expand Up @@ -1067,7 +1086,7 @@ public byte atomicReadByte(int addr) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (BYTE_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE)) {
if (HAS_BYTE_VOLATILE_GET) {
return (byte) BYTE_ARR_HANDLE.getVolatile(page, off);
}
synchronized (monitor(addr)) {
Expand All @@ -1083,7 +1102,7 @@ public int atomicReadInt(int addr) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (INT_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE)) {
if (HAS_INT_VOLATILE_GET) {
return (int) INT_ARR_HANDLE.getVolatile(page, off);
}
synchronized (monitor(addr)) {
Expand All @@ -1099,7 +1118,7 @@ public long atomicReadLong(int addr) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (LONG_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE)) {
if (HAS_LONG_VOLATILE_GET) {
return (long) LONG_ARR_HANDLE.getVolatile(page, off);
}
synchronized (monitor(addr)) {
Expand All @@ -1115,7 +1134,7 @@ public short atomicReadShort(int addr) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (SHORT_ARR_HANDLE.isAccessModeSupported(AccessMode.GET_VOLATILE)) {
if (HAS_SHORT_VOLATILE_GET) {
return (short) SHORT_ARR_HANDLE.getVolatile(page, off);
}
synchronized (monitor(addr)) {
Expand All @@ -1131,7 +1150,7 @@ public void atomicWriteByte(int addr, byte value) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (BYTE_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE)) {
if (HAS_BYTE_VOLATILE_SET) {
BYTE_ARR_HANDLE.setVolatile(page, off, value);
return;
}
Expand All @@ -1148,7 +1167,7 @@ public void atomicWriteInt(int addr, int value) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (INT_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE)) {
if (HAS_INT_VOLATILE_SET) {
INT_ARR_HANDLE.setVolatile(page, off, value);
return;
}
Expand All @@ -1165,7 +1184,7 @@ public void atomicWriteLong(int addr, long value) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (LONG_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE)) {
if (HAS_LONG_VOLATILE_SET) {
LONG_ARR_HANDLE.setVolatile(page, off, value);
return;
}
Expand All @@ -1182,7 +1201,7 @@ public void atomicWriteShort(int addr, short value) {
try {
byte[] page = pages[addr >>> PAGE_SHIFT];
int off = addr & PAGE_MASK;
if (SHORT_ARR_HANDLE.isAccessModeSupported(AccessMode.SET_VOLATILE)) {
if (HAS_SHORT_VOLATILE_SET) {
SHORT_ARR_HANDLE.setVolatile(page, off, value);
return;
}
Expand Down
Loading