Tidy repository structure: root docs, dead pipeline, fork doc copies, README/Makefile - #415
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 700b1b2deb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…wers into docs/plans and docs/specs
The repo root carried 26 SCENARIOS/EXECUTION/STARMAP checklists that no
code or CI reads. They now live in docs/scenarios/<engine>/. The two
scenario docs under mysql/semantic (a non-Go directory) move there too.
docs/superpowers/{plans,specs} held 75 dated files in the same format as
docs/plans, produced by a different tool. They are merged into
docs/plans and a new docs/specs; Go comments and cross-references are
updated. The quality corpora's `-- @source:` comments and
engine-capability-guide now point at the new paths.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…k, move prompts to scripts/prompts
The March-2026 pg-semantic Python pipeline (scripts/pg-semantic, its
driver/metrics scripts, the */semantic artifact directories, the
.gemini skills, the root PG_SEMANTIC_INVENTORY.json, metrics.db and
the four .skill zips) has not been touched since 2026-03-21 and nothing
in Go or CI reads it. The four scripts/pg-*-skill directories already
declared themselves deprecated. pg/catalog/PROGRESS.json pointed at the
deleted pipeline as its replacement.
Also removes files that were tracked despite matching .gitignore
(parser/{driver,status}.sh) or that are session output
(pg/catalog/logs/*.log, __pycache__), and extends .gitignore so they
cannot come back.
Agent prompt templates move from scripts/ to scripts/prompts/; driver.sh,
dashboard.go and extract-bnf.sh follow. Hardcoded /Users/... paths in
the prompts and parser SKILL.md files become `<repo root>`.
stream-filter.py drops its optional hook into the deleted metrics.py.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…pg and mysql redshift was forked from pg and mariadb/tidb from mysql with every PROGRESS.json, SKILL.md, SCENARIOS-*.md and scenarios_bug_queue file copied along. The copies were byte-identical to the originals and nothing read them. Test comments now point at the parent engine's file. Files that a Go test actually opens (PAREN_AUDIT*, PARSER_DISPATCH_AUDIT.md, SPLIT_COVERAGE.json, compat/report.md, BNF catalogs) stay. redshift/README.md, previously a copy of pg's, now describes the Redshift package. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The status table listed four engines and still called the MySQL catalog "Planned". It now lists every engine with its packages, and the layout tree matches the reorganised docs/ and scripts/. The Makefile generates a test-<engine> target per engine and adds test-short, the CI suite. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
rebelice
force-pushed
the
claude/omni-structure-cleanup-a69ae7
branch
from
September 14, 2026 02:41
700b1b2 to
f6c98f7
Compare
…e module from make test Review follow-ups. The README claimed every root package exposes Parse; partiql only exports Split and elasticsearch exports ParseElasticsearchREST, so the entry points are now listed per engine. `make test` also runs harness/conformance, a nested module ./... does not reach, to match CI. The spanner harness fails without a live emulator, so it gets its own test-spanner target instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
|
Rebased onto main (8 new commits, including #422 dropping
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab632d4268
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CI also runs harness/googlesql-spanner against an emulator, which make test skips on purpose. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
|
Addressed the follow-up on README.md:115: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structure-only cleanup. No parser, catalog, or test logic changes; the single non-comment Go change is the prompt path in
scripts/dashboard.go.SCENARIOS-*/EXECUTION-*/STARMAP-*docs moved todocs/scenarios/<engine>/.PG_SEMANTIC_INVENTORY.json,metrics.db, four.skillzips deleted. Root now holds onlygo.mod,Makefile,README.md,LICENSE,tools.goand the engine directories.docs/docs/superpowers/{plans,specs}(75 files, same format asdocs/plans) merged intodocs/plans/and newdocs/specs/. Go comments and cross-references updated.scripts/pg-semantic/, its driver/metrics scripts,pg/semantic,redshift/semantic,mariadb/semantic,.gemini/skills, the four self-declared-deprecatedscripts/pg-*-skill/dirs,docs/pg-semantic-pipeline-migration.md,pg/catalog/PROGRESS.json. Nothing in Go or CI referenced any of it.__pycache__,pg/catalog/logs/*.log(agent session logs with local paths), and `mysqlscripts/scripts/prompts/;driver.sh,dashboard.go,extract-bnf.shfollow. Hardcoded/Users/rebeliceyang/...paths in prompts and parserSKILL.mdfiles replaced with<repo root>.stream-filter.pyloses its hook into the deletedmetrics.py.redshift(fork ofpg) andmariadb/tidb(forks ofmysql) carried byte-identical copies of the parent'sPROGRESS.json,SKILL.md,SCENARIOS-*.md,scenarios_bug_queue/. Deleted; test comments now point at the parent's file. Files a Go test actually opens (PAREN_AUDIT*,PARSER_DISPATCH_AUDIT.md,SPLIT_COVERAGE.json,compat/report.md, BNF catalogs) stay.redshift/README.mdrewritten (it was pg's README verbatim).test-<engine>for every engine and addstest-short.Net: 403 files, +577 / −27,324 lines.
Not done on purpose
docs/plans/historical plans keep their references to now-deleted paths; they are records of the time.gofmt -lbut were already unformatted onmain; left alone.analysisvssemanticnaming) are out of scope.Test plan
go build ./...go test -short ./...(the CI suite) passespg/parserandredshift/parserPAREN lint tests,redshift/compat,pg/splittest,mysql|mariadb|tidb/parser -run TestVerify,mysql|mariadb/validatedocs/plansmentions remain)🤖 Generated with Claude Code