Go private ping msg Change ping message format to JSON#114
Open
hzbnb wants to merge 1 commit into
Open
Conversation
Prior sending ping was incorrect, an error would be received. The correct format should be {"op": "ping"}.
3697503
approved these changes
May 6, 2026
Musthaq22
approved these changes
May 7, 2026
| go func() { | ||
| for range ticker.C { | ||
| err := c.WriteMessage(websocket.TextMessage, []byte("ping")) | ||
| err := c.WriteMessage(websocket.TextMessage, []byte(`{"op": "ping"}`)) |
Musthaq22
reviewed
May 24, 2026
Author
|
Thanks for the reviews. Could a maintainer with write access please help merge this PR if everything looks good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior sending ping was incorrect, an error would be received. The correct format should be {"op": "ping"}.