Fix dislike count not rendering after LeetCode icon markup change - #9
Open
pseudo-bot wants to merge 1 commit into
Open
Fix dislike count not rendering after LeetCode icon markup change#9pseudo-bot wants to merge 1 commit into
pseudo-bot wants to merge 1 commit into
Conversation
## What
Updated the thumbs-up/down selectors to match LeetCode's current DOM.
## Why
LeetCode's dynamic layout no longer renders the `data-icon` attribute on the
thumb SVGs — the icon is now identified only by the FontAwesome class
(`fa-thumbs-up` / `fa-thumbs-down`). As a result `querySelector('[data-icon="thumbs-down"]')`
returned `null`, the count div was never injected, and the dislike count stopped showing.
(Like/dislike values still logged because the fetch runs before the DOM step.)
## Change
- `THUMBS_UP_SELECTOR` → `'svg.fa-thumbs-up, [data-icon="thumbs-up"]'`
- `THUMBS_DOWN_SELECTOR` → `'svg.fa-thumbs-down, [data-icon="thumbs-down"]'`
Kept the legacy `[data-icon=...]` selector as a fallback for backward compatibility.
## Testing
- Load unpacked at `chrome://extensions`
- Open a `leetcode.com/problems/*` page
- Dislike count now renders next to the thumbs-down button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updated the thumbs-up/down selectors to match LeetCode's current DOM.
Why
LeetCode's dynamic layout no longer renders the
data-iconattribute on the thumb SVGs — the icon is now identified only by the FontAwesome class (fa-thumbs-up/fa-thumbs-down). As a resultquerySelector('[data-icon="thumbs-down"]')returnednull, the count div was never injected, and the dislike count stopped showing. (Like/dislike values still logged because the fetch runs before the DOM step.)Change
THUMBS_UP_SELECTOR→'svg.fa-thumbs-up, [data-icon="thumbs-up"]'THUMBS_DOWN_SELECTOR→'svg.fa-thumbs-down, [data-icon="thumbs-down"]'Kept the legacy
[data-icon=...]selector as a fallback for backward compatibility.Testing
chrome://extensionsleetcode.com/problems/*page