Chore/sincronizar fork con version relajada de rubyzip - #4
Merged
domingo2000 merged 19 commits intoAug 3, 2026
Merged
Conversation
- this seems to have changed with newer unrtf versions - missing the header we fail to strip away the other leading comments
- removed 2.6 from the list of tested ruby versions, added more recent ones.
- fixes errors with AS 7.1 as described in rails/rails#49495 - as per https://guides.rubyonrails.org/active_support_core_extensions.html#cherry-picking-a-definition, active_support itself should always be required.
Using "quiet" at end of the command will suppress the messages regarding image resolution and empty pages.
When calling an external command and reading the output, `io.read` returns `""` when no output is available, but `io.read(max_size)` returns `nil` instead of `""`. This return value is then converted to a string with `to_s`, and since ruby 2.7, `nil.to_s` returns a frozen empty string. Then the `Plaintext::Resolver` calling `gsub!` and `strip!` on this string lead to a `FrozenError: can't modify frozen String`. This is fixed by duplicating the string if it is frozen.
Avoid FrozenError with empty images
This avoids a "NoMethodError: undefined method '+@' for nil".
Resolver returns nil if the handler returns nil
Relajamos la version de rubyzip para que permita updates en los otros proyectos al igual como lo hizo el proyecto upstream
Emil-IA
reviewed
Jul 21, 2026
Asi al ir actualizando el fork es mas sencillo tenemos los tests para ver correctitud
Una suite de test caida no sirve de nada. Hacemos cambios a la suite para que pase con las modificaciones del fork
domingo2000
force-pushed
the
chore/sincronizar-fork-con-version-relajada-de-rubyzip
branch
from
July 21, 2026 22:53
5005206 to
b1703ce
Compare
javieromar7
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sincronizamos con upstream manteniendo los cambios que se hicieron en este fork. De esta forma relajamos la versión requerida de rubyzip igual como se hizo en el upstream.
Esto destraba todas aquellas gemas que requieren rubyzip >= 3.0.
Los primeros 19 commits son solamente sincronización.
Los ultimos 2
La gema prácticamente no cambia asi que futuros syncs del forks solo deberían ser de dependencias y por lo tanto vale la pena que los tests si pasen y nos sirvan de verificador para automatizar más el sync.
Revisé con claude opus y a mano también que todos los usos de RubyZip son compatibles con los breaking changes de rubyzip 3.0 asi que no deberíamos tener problema de actualizar a rubyzip 3 en el futuro.