Pipeline upload: look for secrets within trigger step build.env - #4116
Open
DrJosh9000 wants to merge 1 commit into
Open
Pipeline upload: look for secrets within trigger step build.env#4116DrJosh9000 wants to merge 1 commit into
DrJosh9000 wants to merge 1 commit into
Conversation
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found. This changes pipeline-upload secret detection, so I’m leaving the final call to a human reviewer.
Want to dig deeper?
The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 7127, then answer my questions about the findings.
DrJosh9000
enabled auto-merge
July 22, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trigger steps can contain env blocks too: under
build. In pipeline upload, include these in the secret search.Context
Buildsworth outputted some tokens upon the v4 branch: #3807 (comment)
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I happen to know how this works.