build: raise MSRV to Rust 1.98 and resolve new clippy lints - #6748
Merged
Conversation
Rust 1.98's clippy introduced clippy::unused_async_trait_impl and
clippy::chunks_exact_to_as_chunks, which fired on ~120 pre-existing
call sites across the workspace and blocked the MSRV bump documented
in ci.yml's toolchain-pin rationale comment.
Side-effect-free async fn bodies are converted to
fn -> impl Future<Output = T> + Send { std::future::ready(body) }.
Side-effecting bodies (mutation, panic!, process-global calls) stay
genuine async fn with #[allow(clippy::unused_async_trait_impl)], since
std::future::ready evaluates eagerly at construction time rather than
at first poll and would otherwise fire even when a tokio::select! arm
loses its race and is dropped unpolled. The Channel trait now documents
this contract explicitly.
Bumps rust-version to "1.98" in Cargo.toml and updates all CI
toolchain pins accordingly.
Closes #6746
github-actions
Bot
added
build
github-actions
Bot
added
skills
bug-ops
enabled auto-merge (squash)
August 25, 2026 02:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy::unused_async_trait_implandclippy::chunks_exact_to_as_chunksviolation surfaced by Rust 1.98's clippy across the workspace (~120 sites), which had been blocking the MSRV bump documented inci.yml's toolchain-pin rationale comment.async fnbodies convert tofn -> impl Future<Output = T> + Send { std::future::ready(body) }.panic!, process-global calls) stay genuineasync fnwith#[allow(clippy::unused_async_trait_impl)]—std::future::readyevaluates eagerly at construction time rather than at first poll, and would otherwise fire the side effect even when a losingtokio::select!arm is dropped unpolled. TheChanneltrait now documents this contract explicitly, withBenchmarkChannel::recv(the site of a confirmed regression caught during review) as the precedent comment.rust-versionto"1.98"inCargo.tomland updates all 12 CItoolchain:pins inci.ymlaccordingly (ci-non-linux.yml/release.yml/codeql.ymlalready use rollingstable, left untouched). Updates MSRV references in README, AGENTS.md, per-crate READMEs, and specs.Test plan
cargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins(15402 passed, 0 failed, 42 skipped)RUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace --features "desktop,ide,server,chat,pdf,scheduler"main, all gates re-run and green post-rebaseCloses #6746