Find nearest valid source location by path#21
Open
maratori wants to merge 7 commits into
Open
Conversation
Member
|
Can you add in the test? |
Contributor
Author
|
Yes, is the original test from the issue good enough? |
Contributor
Author
|
I've added a test |
Contributor
Author
|
@bufdev could you please have a look at the PR? |
emcfarlane
reviewed
Apr 27, 2026
emcfarlane
left a comment
emcfarlane
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Before merging I wanted to flag an alternative approach to the nearest source location algo. I think this can be improved by first walking downwards to capture the closest descendant before falling back to the nearest ancestor. Added a comment highlighting this approach. Happy to discuss.
Contributor
Author
|
@emcfarlane, thanks for your review. I agree with all comments and have updated the PR accordingly. |
emcfarlane
reviewed
Apr 28, 2026
emcfarlane
left a comment
emcfarlane
left a comment
Contributor
There was a problem hiding this comment.
Testcases is failing but otherwise lgtm.
emcfarlane
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20