Repository navigation
Conversation
Fix a bug that resulted in an app crash when scrolling to the bottom of the Common Tags page, back to the top and then back to the bottom of it. This was due to nil valueField values being unwrapped.
Owner
|
Thanks for the PR! Your fix fixes it, but the root cause is slightly deeper: we were using a custom class where we shouldn't have. Those valueField properties shouldn't have even existed in that context. |
Contributor
Author
|
I see—thanks for the info and the proper fix! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug that resulted in an app crash when scrolling to the bottom of the Common Tags page, back to the top and then back to the bottom of it (the crash happened right at the end of the screen recording):
ScreenRecording_10-31-2026.23-46-52_1.mov
This was due to nil valueField values being unwrapped.
I've tested and it doesn't crash with this patch.