Skip to content

fix(ci): run documentation checks on stacked PRs - #128

Merged
karakanb merged 1 commit into
mainfrom
fix/stacked-pr-ci
Oct 29, 2026
Merged

karakanb merged 1 commit into
mainfrom
fix/stacked-pr-ci

Conversation

@karakanb

@karakanb karakanb commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Remove only the Docs Build pull_request base-branch filter so documentation changes are checked on stacked PRs targeting feature branches. Keep the docs/** path filter and main-only push trigger.

The short docs/development.md page is required by the root AGENTS.md Documentation section: "After every code change, scan docs/ for areas the change touches and update them in the same change. If nothing existing fits, add a new doc page." No existing docs page covered repository CI. The page documents trigger behavior; it was not added merely to trigger the path-filtered workflow. Retained after scope review under the explicit guidance exception.

Audit

Started from freshly fetched origin/main. CI already accepts all PR bases and neither PR workflow has job conditions restricting the target branch. No pull_request_target workflows exist. Release, edge release, version bump, and Pages deployment workflows are unchanged, including permissions and secrets.

Verification

  • actionlint v1.7.12 passes all seven workflow files.
  • Parsed all workflow YAML and confirmed the only semantic workflow change is removal of Docs Build pull_request.branches.
  • Checked 12 PR branch/path combinations: main, feature, feature/parent, stack/one/two, with root/nested docs files and a non-docs file. Feature-targeted docs PRs now match; non-docs PRs still do not.
  • Checked 12 push branch/path controls: all unchanged.
  • git diff --check passes.
  • GitHub CI verify and Build Documentation both passed on ffae9ec. Branch/path coverage is static validation, not a live feature-targeted PR test.

No deployments or shared settings changes were made. Scope review required no new commit or push, and published history was not rewritten.

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in Greptile

[Medium impact] The PR appears safe to merge.

Reviews (1) · Last reviewed commit: "fix(ci): build docs for stacked pull req..." · Reviewed by Greptile

@karakanb karakanb added the hotfix label Oct 29, 2026 — with Amp for GitHub
@karakanb
karakanb merged commit d803884 into main Oct 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants