Repository navigation
fix(ci): run documentation checks on stacked PRs - #128
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1878a-2ff8-75f7-8ddb-2335d64771e6 Co-authored-by: Burak Karakan <burak.karakan@gmail.com>
|
[Medium impact] The PR appears safe to merge. Reviews (1) · Last reviewed commit: "fix(ci): build docs for stacked pull req..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Remove only the Docs Build pull_request base-branch filter so documentation changes are checked on stacked PRs targeting feature branches. Keep the docs/** path filter and main-only push trigger.
The short docs/development.md page is required by the root AGENTS.md Documentation section: "After every code change, scan docs/ for areas the change touches and update them in the same change. If nothing existing fits, add a new doc page." No existing docs page covered repository CI. The page documents trigger behavior; it was not added merely to trigger the path-filtered workflow. Retained after scope review under the explicit guidance exception.
Audit
Started from freshly fetched origin/main. CI already accepts all PR bases and neither PR workflow has job conditions restricting the target branch. No pull_request_target workflows exist. Release, edge release, version bump, and Pages deployment workflows are unchanged, including permissions and secrets.
Verification
No deployments or shared settings changes were made. Scope review required no new commit or push, and published history was not rewritten.